[PATCH] D145023: [memprof] Refactor tests to generate binaries and profiles on the fly.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 6 15:07:18 PST 2023


dblaikie added a comment.

FWIW, there's a drawback here: Now llvm-profdata is missing test coverage in the llvm subproject. Someone making changes would reasonably expect that "check-llvm" would be adequate to test their changes. So we do try pretty hard to keep tests for code in the same subproject as the code itself. (but yes, also the llvm subproject can't/shouldn't depend on compiler-rt)

& as for version toil - presumably the existing/previous tests for the old version should remain to keep testing that functions correctly.

Perhaps a script to easily update things for new versions would be adequate?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145023/new/

https://reviews.llvm.org/D145023



More information about the llvm-commits mailing list