[PATCH] D142174: [OpenMP] Don't set rpath for system paths
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 6 14:16:33 PST 2023
MaskRay added a comment.
In D142174#4171731 <https://reviews.llvm.org/D142174#4171731>, @JonChesterfield wrote:
> I'm happy with this but agree that "what might be a system path?" is a tricky heuristic. What we want is to exclude the places that the application will search anyway, but that's OS dependent. I'm mostly worried about toolchains installed under /opt or under $HOME so this is good for me. It's also easy to pull later if we reconsider.
Thank you for being considerate the use case. But I don't think we should base the decision on whether `/usr/lib` or `/usr/lib64` is used and make directories different. We should unconditionally disable rpath, regardless of the directory path.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142174/new/
https://reviews.llvm.org/D142174
More information about the llvm-commits
mailing list