[PATCH] D144659: [DirectX backend] remove hlsl.* FnAttr after use.

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXILMetadata.cpp:99
+  EntryProps(Function &F, Attribute &EntryAttr,
+             Triple::EnvironmentType ModuleShaderKind)
       : ShaderKind(ModuleShaderKind) {
----------------
I'm not sure I understand this refactoring... It looks like you're trying to avoid looking up the attribute more than once, but it means you're keeping track of the Attribute and passing it around through layers... I'm not convinced that is beneficial.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144659/new/

https://reviews.llvm.org/D144659