[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

[Aaron Siddhartha Mondal via Phabricator via llvm-commits]

aaronmondal added subscribers: MaskRay, phosek, compnerd, aaronmondal.
aaronmondal added a comment.
Herald added a subscriber: Enna1.
Herald added a project: All.

Hmm I tried to fiddle around with this but I'm out of my depth here. Pulling in @MaskRay @compnerd @phosek in the hopes that one of you is able to provide some insight or pull in someone else who is able to help.

When building a static compiler-rt with thinlto every downstream target breaks because of the missing `__extendxftf2` and `__trunctfxf2`. AFAIU this blocks everyone from using thinlto with compiler-rt.

  ld.lld: error: undefined symbol: __extendxftf2
  >>> referenced by extendsftf2.c:18 (./external/llvm-project-overlay~17-init-bcr.0~llvm_project_overlay~llvm-project/compiler-rt/lib/builtins/extendsftf2.c:18)
  >>>               lto.tmp:(__extendsftf2)
  >>> referenced by extenddftf2.c:18 (./external/llvm-project-overlay~17-init-bcr.0~llvm_project_overlay~llvm-project/compiler-rt/lib/builtins/extenddftf2.c:18)
  >>>               lto.tmp:(__extenddftf2)
  >>> referenced by floattitf.c:75 (./external/llvm-project-overlay~17-init-bcr.0~llvm_project_overlay~llvm-project/compiler-rt/lib/builtins/floattitf.c:75)
  >>>               lto.tmp:(__floattitf)
  >>> referenced 1 more times
  >>> did you mean: __extenddftf2
  >>> defined in: lto.tmp
  
  ld.lld: error: undefined symbol: __trunctfxf2
  >>> referenced by trunctfsf2.c:17 (./external/llvm-project-overlay~17-init-bcr.0~llvm_project_overlay~llvm-project/compiler-rt/lib/builtins/trunctfsf2.c:17)
  >>>               lto.tmp:(__trunctfsf2)
  >>> referenced by trunctfdf2.c:17 (./external/llvm-project-overlay~17-init-bcr.0~llvm_project_overlay~llvm-project/compiler-rt/lib/builtins/trunctfdf2.c:17)
  >>>               lto.tmp:(__trunctfdf2)
  bazel-out/k8-fastbuild-ST-1b2103630309/bin/external/llvm-project-overlay~17-init-bcr.0~llvm_project_overlay~llvm-project/clang/clang-linker-wrapper: error: 'ld.lld' failed

I also vaguely remember this leading to issues with static CUDA linking, but I don't have stacktraces for that :/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53608/new/

https://reviews.llvm.org/D53608