[PATCH] D144337: Prevent line 0 instructions from dividing a lexical block into ranges

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

> Defining UnknownLocations as extern in LexicalScopes.cpp gives a link-time error despite removing the "static" keyword from its definition in DwarfDebug.cpp.

Ah, the layering is in the other direction than I thought (AsmPrinter depends on CodeGen, not vice versa).  Okay, it has to be defined in LexicalScopes and made extern from DwarfDebug.

Please do change over to boolOrDefault for this one flag, which means you can leave the DefaultOnOff enum in DwarfDebug.cpp.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144337/new/

https://reviews.llvm.org/D144337