[PATCH] D145404: [LLVM] Remove support for constant scalable vector GEPs.

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added reviewers: sdesmalen, nikic, reames, david-arm, craig.topper.
paulwalker-arm added inline comments.
Herald added a subscriber: StephenFan.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:2353-2355
-      // If datalayout has no special restrictions on vector data layout,
-      // replace `llvm.vscale` by an equivalent constant expression
-      // to benefit from cheap constant propagation.
----------------
Just being able to remove this wholesale seems optimistic but it doesn't seem to have any relevant test coverage.


================
Comment at: llvm/test/Transforms/InstSimplify/vscale-inseltpoison.ll:157-160
-define <vscale x 4 x ptr> @getelementptr_constant_foldable_1() {
-; CHECK-LABEL: @getelementptr_constant_foldable_1(
-; CHECK-NEXT:    ret <vscale x 4 x ptr> zeroinitializer
-;
----------------
These tests look like blind copies from `vscale.ll` and have no insert_eltement_poison related requirements so I've just remove them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145404/new/

https://reviews.llvm.org/D145404