[PATCH] D144927: [GVNHoist] don't hoist callbr users into the callbr's block

Mon Mar 6 10:22:59 PST 2023

nickdesaulniers added a subscriber: george.burgess.iv.
nickdesaulniers added inline comments.

================
Comment at: llvm/test/Transforms/GVNHoist/hoist-call.ll:124
+
+; FIXME: it should be safe to hoist loads of variable not modified by callbr.
+ at y = global i32 0
----------------
I asked @george.burgess.iv if this fixme is correct; that we ought to be able to do such hoist. George mentioned that maybe AA was messing up. I wrote up a quick test case that disproves that: https://reviews.llvm.org/D145400 (not sure there's any value in landing that or not).  So pretty much not sure about this comment.

@efriedma thoughts?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144927/new/

https://reviews.llvm.org/D144927