[PATCH] D113816: [llvm-reduce] Assert that the number of chunks does not change with reductions

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/tools/llvm-reduce/deltas/Delta.cpp:241
+           "input module is broken after counting chunks");
+    assert(isReduced(Test.getProgram(), Test, CurrentFilepath) &&
+           "input module no longer interesting after counting chunks");
----------------
foad wrote:
> foad wrote:
> > Hi! I've hit this assertion failure because I'm using llvm-reduce to reduce a compile-time hog, so the interestingness test ("does it take longer than 1 second to compile") is not 100% consistent. Of course it seems to me like llvm-reduce ought to support this use case. Any thoughts?
> In any case I think this should be a proper diagnostic, not an assert, like the "Input isn't interesting!" error.
all of what you said sounds good to me


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113816/new/

https://reviews.llvm.org/D113816