[llvm] 8a5d4eb - [docs][NewPM] fix typos in new pass manager docs

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 6 09:18:08 PST 2023


Author: Alex MacLean
Date: 2023-03-06T09:17:56-08:00
New Revision: 8a5d4eb775c644d8683f24817d44c510d2b853b7

URL: https://github.com/llvm/llvm-project/commit/8a5d4eb775c644d8683f24817d44c510d2b853b7
DIFF: https://github.com/llvm/llvm-project/commit/8a5d4eb775c644d8683f24817d44c510d2b853b7.diff

LOG: [docs][NewPM] fix typos in new pass manager docs

Fix some minor errors in the code-block sections of the new pass manager documentation

Reviewed By: aeubanks

Differential Revision: https://reviews.llvm.org/D145325

Added: 
    

Modified: 
    llvm/docs/NewPassManager.rst

Removed: 
    


################################################################################
diff  --git a/llvm/docs/NewPassManager.rst b/llvm/docs/NewPassManager.rst
index a9fa72cf6eb83..d115c4dbc4019 100644
--- a/llvm/docs/NewPassManager.rst
+++ b/llvm/docs/NewPassManager.rst
@@ -92,9 +92,9 @@ Loop, where going through a CGSCC is optional.
   MPM.addPass(createModuleToFunctionPassAdaptor(FunctionFooPass()));
 
   // loop -> function -> cgscc -> module
-  MPM.addPass(createModuleToCGSCCPassAdaptor(createCGSCCToFunctionPassAdaptor(createFunctionToLoopPassAdaptor(LoopFooPass()))));
+  MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(createCGSCCToFunctionPassAdaptor(createFunctionToLoopPassAdaptor(LoopFooPass()))));
   // function -> cgscc -> module
-  MPM.addPass(createModuleToCGSCCPassAdaptor(createCGSCCToFunctionPassAdaptor(FunctionFooPass())));
+  MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(createCGSCCToFunctionPassAdaptor(FunctionFooPass())));
 
 
 A pass manager of a specific IR unit is also a pass of that kind. For
@@ -386,7 +386,7 @@ checked if they are invalidated:
 .. code-block:: c++
 
   bool FooAnalysisResult::invalidate(Function &F, const PreservedAnalyses &PA,
-                                     FunctionAnalysisManager::Invalidator &) {
+                                     FunctionAnalysisManager::Invalidator &Inv) {
     auto PAC = PA.getChecker<FooAnalysis>();
     if (!PAC.preserved() && !PAC.preservedSet<AllAnalysesOn<Function>>())
       return true;


        


More information about the llvm-commits mailing list