[compiler-rt] 0bd4499 - [scudo] Temporarily disable GetRssFromBuffer test

[Chia-hung Duan via llvm-commits]

Author: Chia-hung Duan
Date: 2023-03-06T16:38:18Z
New Revision: 0bd4499b967909e134fec7fa7b30bebe06835758

URL: https://github.com/llvm/llvm-project/commit/0bd4499b967909e134fec7fa7b30bebe06835758
DIFF: https://github.com/llvm/llvm-project/commit/0bd4499b967909e134fec7fa7b30bebe06835758.diff

LOG: [scudo] Temporarily disable GetRssFromBuffer test

This is a flaky test and may not test the thing it expected to verify.
E.g., it doesn't dirty the pages so the memory usage may not be reflected
on the RSS.

Reviewed By: cferris

Differential Revision: https://reviews.llvm.org/D145126

Added: 
    

Modified: 
    compiler-rt/lib/scudo/standalone/tests/common_test.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/scudo/standalone/tests/common_test.cpp b/compiler-rt/lib/scudo/standalone/tests/common_test.cpp
index a322a01fb9391..a9794f03fd7a5 100644
--- a/compiler-rt/lib/scudo/standalone/tests/common_test.cpp
+++ b/compiler-rt/lib/scudo/standalone/tests/common_test.cpp
@@ -69,9 +69,11 @@ TEST(ScudoCommonTest, Zeros) {
   unmap(P, Size, 0, &Data);
 }
 
-#if SCUDO_LINUX && !defined(__powerpc__)
-// This test fails intermediately on PPC, which is why this test is disabled
-// for now on this platform.
+#if 0
+// This test is temorarily disabled because it may not work as expected. E.g.,
+// it doesn't dirty the pages so the pages may not be commited and it may only
+// work on the single thread environment. As a result, this test is flaky and is
+// impacting many test scenarios.
 TEST(ScudoCommonTest, GetRssFromBuffer) {
   constexpr int64_t AllocSize = 10000000;
   constexpr int64_t Error = 3000000;
@@ -88,6 +90,6 @@ TEST(ScudoCommonTest, GetRssFromBuffer) {
     EXPECT_LE(std::abs(Rss - AllocSize - Prev), Error);
   }
 }
-#endif // SCUDO_LINUX
+#endif
 
 } // namespace scudo