[PATCH] D145308: [lld][WebAssembly] Initial support for stub objects

[Paulo Matos via Phabricator via llvm-commits]

pmatos added inline comments.


================
Comment at: lld/docs/WebAssembly.rst:81
+  Like ``--allow-undefined``, but the filename specified a flat list of
+  symbols, one per line, which care allowed to be undefined.
+
----------------
typo: s/care/are/


================
Comment at: lld/docs/WebAssembly.rst:201
+Another way to specify imports and exports is via a "stub object".  This
+features is inspired by the ELF stub objects which are supported by the solaris
+linker.  Stub objects are text files that can be passed as normal linker inputs,
----------------
typo: s/This features/This feature/


================
Comment at: lld/wasm/Driver.cpp:831
+        LLVM_DEBUG(llvm::dbgs()
+                   << "sub symbol not in symtab: " << name << "\n");
+        continue;
----------------
Here you mean "stub symbol" , right? Same issue in other messages in this hunk.


================
Comment at: lld/wasm/SymbolTable.cpp:45
+    f->parse();
+    stubFiles.push_back(f);
+    return;
----------------
What happens with stub files that have duplicates? Say

foo: x, y
foo: z

Should the dependencies be x, y, z or should this be disallowed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145308/new/

https://reviews.llvm.org/D145308