[PATCH] D145373: Fix #61122
Jakub Kuderski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 6 07:08:54 PST 2023
kuhar accepted this revision.
kuhar added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the fix. Just a couple of nits.
> Fix #61122
Could you make the commit line more specific? Maybe something like 'Fix SafeIntIterator reference type'.
================
Comment at: llvm/unittests/ADT/SequenceTest.cpp:299
+TEST(SequenceTest, Repro) {
+ std::vector<int> vals = {1, 2, 3};
----------------
nit: Could you rename this or add a comment explaining what the intention is behind this test?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145373/new/
https://reviews.llvm.org/D145373
More information about the llvm-commits
mailing list