[PATCH] D145323: AMDGPU: Fix LiveVariables verifier error for values defined before SI_END_CF

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh added a comment.

Patch LGTM, I just have a few questions to try and understand it better



================
Comment at: llvm/lib/Target/AMDGPU/SILowerControlFlow.cpp:519
+      // accidentally add the original block to AliveBlocks. AliveBlocks only
+      // includes blocks which are live through, which excludes live outs and
+      // local defs.
----------------
What does live through mean in this context?


================
Comment at: llvm/test/CodeGen/AMDGPU/lower-control-flow-live-variables-update.xfail.mir:3
+
+# CHECK: *** Bad machine code: LiveVariables: Block missing from AliveBlocks ***
+# CHECK-NEXT: function:    live_variables_update_block_split_split_def_before_si_end_cf_live_out
----------------
Is this a test case that will be fixed in a future patch?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145323/new/

https://reviews.llvm.org/D145323