[PATCH] D144570: [X86] Add support for using Sched/Codesize information to `X86FixupInstTuning` Pass.
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 6 04:52:02 PST 2023
RKSimon added a comment.
Maybe use has_value() instead of nullopt comparisons?
================
Comment at: llvm/lib/Target/X86/X86FixupInstTuning.cpp:77
+
+ return std::nullopt;
+}
----------------
Maybe?
if (NewVal.has_value() && CurVal.has_value() && *NewVal != *CurVal)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144570/new/
https://reviews.llvm.org/D144570
More information about the llvm-commits
mailing list