[PATCH] D145279: Attributor: Assume handling for nofpclass

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 6 04:49:21 PST 2023


arsenm added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:230
+                                                Value *LHS, Value *RHS,
+                                                bool LookThroughSrc = true);
 
----------------
sameerds wrote:
> Would "LookThroughAbsForLHS" be a more specific name for this argument?
The point is to exactly report the same incoming value, and fabs is more specific about what it's doing. This could perform other tricks by looking at fneg and fcopysign in the future


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145279/new/

https://reviews.llvm.org/D145279



More information about the llvm-commits mailing list