[PATCH] D145358: [AMDGPU] Use UniformityAnalysis in CodeGenPrepare

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds accepted this revision.
sameerds added inline comments.


================
Comment at: llvm/lib/Analysis/UniformityAnalysis.cpp:36
     if (TTI->isSourceOfDivergence(&I)) {
-      assert(!I.isTerminator());
+      assert(!I.isTerminator() || isa<InvokeInst>(I));
       markDivergent(I);
----------------
arsenm wrote:
> Pierre-vh wrote:
> > foad wrote:
> > > What was the purpose of the assert? Maybe remove it instead, or insert that the instruction has non-void type or something?
> > Not sure what the assert is for, I think @sameerds wrote it
> > 
> I'd guess this should be I.getType()->isFirstClassType()
Unfortunately, this is in a template that needs to work with MIR too. I am okay with just dropping the assert.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145358/new/

https://reviews.llvm.org/D145358