[PATCH] D144982: Fix -fsplit-lto-unit with ifuncs

Daniel Kiss via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 6 03:24:01 PST 2023


danielkiss marked an inline comment as done.
danielkiss added a comment.

In D144982#4169480 <https://reviews.llvm.org/D144982#4169480>, @tejohnson wrote:

> I'm a little confused - did we create an illegal split module by cloning the ifunc to the regular LTO split module? Should the handling in CloneModule (particularly with its use of the ShouldCloneDefinition callback) be changed so that ifunc are not cloned if their resolver is not cloned?

`simplifyExternals` turns the resolver to external. Externals won't be in the module summary which will be referenced by the ifunc.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144982/new/

https://reviews.llvm.org/D144982



More information about the llvm-commits mailing list