[PATCH] D145338: [InstCombine] Add tests for `(icmp eq/ne bitreverse(x), C)`; NFC

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 6 01:40:31 PST 2023

Previous message: [PATCH] D145339: [InstCombine] Add transform `(icmp eq/ne bitreverse(x), C)` -> `(icmp eq/ne x, bitreverse(C))`
Next message: [PATCH] D145338: [InstCombine] Add tests for `(icmp eq/ne bitreverse(x), C)`; NFC
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

nikic added a comment.

Could you please add a negative test with a non-equality predicate? (We should not fold e.g. `icmp ult`.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145338/new/

https://reviews.llvm.org/D145338

Previous message: [PATCH] D145339: [InstCombine] Add transform `(icmp eq/ne bitreverse(x), C)` -> `(icmp eq/ne x, bitreverse(C))`
Next message: [PATCH] D145338: [InstCombine] Add tests for `(icmp eq/ne bitreverse(x), C)`; NFC
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list