[PATCH] D143841: [Propeller] Make decoding BBAddrMaps trace through relocations

Mon Mar 6 00:24:24 PST 2023

aidengrossman added inline comments.

================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:7098
+  if(!SecRelocMapOrErr) {
+    handleAllErrors(SecRelocMapOrErr.takeError(), [&](StringError &SE) {
+      this->reportUniqueWarning(SE.getMessage());
----------------
jhenderson wrote:
> I have a slight concern that this is slightly fragile - if the underlying code changes to emit other kinds of errors, this will fail here. It should probably handle the error base class, in some manner, so that we don't end up with a surprise crash in the future.
Definitely a valid concern. I fixed up the call sites in `ELFDumper.cpp` but forgot to do it here. Should be fixed in the latest revision.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143841/new/

https://reviews.llvm.org/D143841