[PATCH] D145051: [ADCE] Only remove debug intrinsics if non debug instructions are removed

Sun Mar 5 22:07:39 PST 2023

uabelho added a comment.

In D145051#4168131 <https://reviews.llvm.org/D145051#4168131>, @dblaikie wrote:

> In D145051#4166919 <https://reviews.llvm.org/D145051#4166919>, @uabelho wrote:
>
>> In D145051#4166656 <https://reviews.llvm.org/D145051#4166656>, @nikic wrote:
>>
>>> I think what we can do instead is to mark MemorySSA as preserved if only debuginfo intrinsics have been removed. (This is safe, MSSA explicitly never tracks debuginfo intrinsics.)
>>
>> Does everyone agree this is the way forward then? If so I can put up a patch doing that on Monday.
>
> Probably worth picking up the discussion on the original bug. I think @aeubanks had speculated about this other path - it does seem more brittle (playing whack-a-mole with preserving analyses - can we say it preserves all analyses despite removing debug intrinsics? And then whack-a-mole in the opposite direction to flag certain analyses as unpreserved if they do get broken by the intrinsic removals?)/might have some other concerns.

Sure, let's continue in https://github.com/llvm/llvm-project/issues/58285

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145051/new/

https://reviews.llvm.org/D145051