[PATCH] D144189: [AIX][CodeGen] Storage Locations for Constant Pointers

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-roptr.ll:22
+;CHECK-NEXT:    .vbyte	4, _ZL1p[RO]
+;OBJ-DAG: 000001a8 l       .text	00000004 (idx: 31) _ZL1p[RO]
+ at q = thread_local constant ptr @_ZL1p, align 4
----------------
I suggest replacing all of the address and symbol table index fields with regular expressions.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-roptr.ll:28-29
+;CHECK-NEXT:    .vbyte	4, _ZL1p[RO]
+;OBJ-DAG: 0000030c l     O .data	00000004 (idx: 89) .q[TC]
+;OBJ-DAG: 00000310 l     O .data	00000004 (idx: 91) q[TC]
+;OBJ-DAG: 00000000 g     O .tdata	00000004 (idx: 93) q[TL]
----------------
The TOC entries are not interesting for our purposes here.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-roptr.ll:37
+;OBJ-DAG: 000001ac g       .text	00000004 (idx: 33) u[RO]
+ at dd = global %struct.DD zeroinitializer, align 4
+ at _ZTV2DD = linkonce_odr unnamed_addr constant { [5 x ptr], [5 x ptr] } { [5 x ptr] [ptr null, ptr null, ptr null, ptr @_ZTI2DD, ptr @_ZN2DD1fEv], [5 x ptr] [ptr inttoptr (i32 -4 to ptr), ptr inttoptr (i32 -4 to ptr), ptr inttoptr (i32 -4 to ptr), ptr @_ZTI2DD, ptr @_ZThn4_N2DD1fEv] }, align 4
----------------
I think the rest of the file (including the definition of `dd`) can be removed.


================
Comment at: llvm/test/CodeGen/PowerPC/aix64-xcoff-roptr.ll:1
+; RUN: llc -mtriple powerpc64-ibm-aix-xcoff -mroptr < %s | FileCheck %s
+; RUN: llc -mtriple powerpc64-ibm-aix-xcoff -mroptr -filetype=obj -o %t.o < %s
----------------
hubert.reinterpretcast wrote:
> Same comments as for the 32-bit case.
Same new comments as for the 32-bit case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144189/new/

https://reviews.llvm.org/D144189