[PATCH] D144714: [JITLink] Introduce virtual offsets for Symbol definitions in LinkGraph

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.

My gut reaction is to want to introduce a new "target flags" concept into Symbol, rather than using/abusing the address. On the other hand I think that using/abusing the address is the standard for thumb, and people might get thrown if this bit _isn't_ where they expect it to be.

If I'm right about that then the question is whether we want to privilege the generic LinkGraph assumptions over the thumb ones, or vice versa.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144714/new/

https://reviews.llvm.org/D144714