[PATCH] D144125: [VPlan] VPWidenIntOrFpInductionRecipe inherits from VPHeaderPHIRecipe

Sun Mar 5 12:10:32 PST 2023

fhahn added a comment.

In D144125#4151066 <https://reviews.llvm.org/D144125#4151066>, @michaelmaitland wrote:

> In D144125#4150975 <https://reviews.llvm.org/D144125#4150975>, @fhahn wrote:
>
>> 
>
>
>
>> After changing VPWidenIntOrFpInductionRecipe, are the other changes still needed?
>
> I think this change reduces class bloat (since not all recipes are phi like, header phi like, or generate backedge). It also makes it so we only use RecipeTy in classof and uses `isa` to determine whether something `isPhi`.
>
> I have some changes I plan to upstream in the near future that I think will give these util functions an even stronger justification for existing. If you don't think that the justifications i give are strong enough now, I am happy to remove them from this patch and include them in the future patch I mentioned.

Usually we try to keep unrelated changes as separate patches, if possible. It seems like fixing the inheritance can be done on its own and the isPhi changes can be done & discussed separately from that issue.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144125/new/

https://reviews.llvm.org/D144125