[PATCH] D145323: AMDGPU: Fix LiveVariables verifier error for values defined before SI_END_CF

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 5 11:44:17 PST 2023


arsenm created this revision.
arsenm added reviewers: AMDGPU, critson, foad, Pierre-vh, rampitec.
Herald added subscribers: kosarev, mstorsjo, StephenFan, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

GlobalISel happens to insert some constant materializes before SI_END_CF
in one test. These need to be excluded from AliveBlocks since they
are defined in the original block and used in the split block,
so they aren't fully alive through either block.

     

The case where the value defined in the first block which was originally used
in a later block is still broken.

      

Avoids a verifier error in a future patch.


https://reviews.llvm.org/D145323

Files:
  llvm/lib/Target/AMDGPU/SILowerControlFlow.cpp
  llvm/test/CodeGen/AMDGPU/lower-control-flow-live-variables-update.mir
  llvm/test/CodeGen/AMDGPU/lower-control-flow-live-variables-update.xfail.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145323.502450.patch
Type: text/x-patch
Size: 8422 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230305/78b31190/attachment.bin>


More information about the llvm-commits mailing list