[PATCH] D144783: [ELF] Move getSectionAndRelocations to ELF.cpp from ELFDumper.cpp

[Rahman Lavaee via Phabricator via llvm-commits]

rahmanl added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6212
+    handleAllErrors(StackSizeRelocMapOrErr.takeError(), [&](StringError &SE) {
+      reportUniqueWarning(SE.getMessage());
+    });
----------------
rahmanl wrote:
> Can we turn these into failures without breaking any tests? I think early return is not consistent with reporting warnings anymore.
Alternatively, report a warning similar to
`reportWarning("unable to print stack size: " + StackSizeRelocMapOrErr.takeError().getMessage())`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144783/new/

https://reviews.llvm.org/D144783