[PATCH] D144982: Fix -fsplit-lto-unit with ifuncs

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

I'm a little confused - did we create an illegal split module by cloning the ifunc to the regular LTO split module? Should the handling in CloneModule (particularly with its use of the ShouldCloneDefinition callback) be changed so that ifunc are not cloned if their resolver is not cloned?



================
Comment at: llvm/test/ThinLTO/X86/ifunc_splitlto.ll:30
+!1 = !{ptr @g}
+!2 = !{i64 0, !2}
+!3 = distinct !{}
----------------
Is the second !2 supposed to be !3? Otherwise there is a circular metadata reference and no use of !3.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144982/new/

https://reviews.llvm.org/D144982