[PATCH] D145149: [UTC] Enable --function-signature by default

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D145149#4168583 <https://reviews.llvm.org/D145149#4168583>, @arichardson wrote:

> Thanks for working on this! How bad is the test diff if you remove the hardcoded --version=1 from lit.local.cfg?

Beyond the actual functional diff, this will touch every single UTC test simply due to the addition of `--version 2` to UTC_ARGS. I'd need an update_utc_test_checks.py script for that ;)



================
Comment at: llvm/utils/UpdateTestChecks/common.py:252
 
       args = parser.parse_args(argv[1:])
       if argparse_callback is not None:
----------------
arichardson wrote:
> I think this would be the place to add `if args.version >= 2: args.function_signature = True`
That wouldn't be sufficient due to the on-the-fly flags update feature (that probably isn't worth the complexity it introduces -- we should consider removing it.) I could extract the parse_args() calls into a common helper though, where we could do this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145149/new/

https://reviews.llvm.org/D145149