[PATCH] D145293: [GlobalOpt] Don't replace the aliasee if it has other references.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a reviewer: pcc.
nikic added a subscriber: pcc.
nikic added a comment.

Looks reasonable to me, but @MaskRay or @pcc should review this wrt alias semantics. Note that you have a failing GlobalOpt test.



================
Comment at: llvm/lib/Transforms/IPO/GlobalOpt.cpp:2236
   // and other attributes of the aliasee with those of the alias.
   if (hasMoreThanOneUseOtherThanLLVMUsed(*Target, U))
     return Ret;
----------------
The "OtherThanLLVMUsed" part here no longer makes sense?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145293/new/

https://reviews.llvm.org/D145293