[PATCH] D123515: [RISCV] Support '.option arch' directive

Fri Mar 3 23:14:45 PST 2023

jrtc27 added inline comments.

================
Comment at: llvm/test/MC/RISCV/option-arch.s:97
+#CHECK: .option arch, rv32i2p0_m2p0_a2p0_c2p0
+.option arch, rv32i2p0_m2p0_a2p0_c2p0
+
----------------
kito-cheng wrote:
> Spec and binutils implementation are both string here, so it should be `.option arch, "rv32i2p0_m2p0_a2p0_c2p0"`.
It being a string isn't what the proposed spec says, and doesn't make sense to me; +c but "rv64ic" is inconsistent and pointless. If binutils requires it to be a string then fix binutils to not be weird and instead follow the more sensible spec.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123515/new/

https://reviews.llvm.org/D123515