[PATCH] D143841: [Propeller] Make decoding BBAddrMaps trace through relocations

[Aiden Grossman via Phabricator via llvm-commits]

aidengrossman added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:7102
+  llvm::MapVector<const Elf_Shdr *, const Elf_Shdr *> Sections;
+  this->getSectionAndRelocations(IsMatch, Sections);
+  for (auto const& [Sec, RelocSec] : Sections) {
----------------
jhenderson wrote:
> This (currently) returns an `Error`, so that return value needs capturing and checking.
This was originally using the implementation of `getSectionAndRelocations` from within `ELFDumper.cpp` that wrapped around the actual implementation, but I've removed that abstraction due to how we're now handling errors and also to improve clarity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143841/new/

https://reviews.llvm.org/D143841