[PATCH] D145275: [CGP] Hoist allocas used in catchpad instructions, if they are not in the entry block.

LuoYuanke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 3 16:39:05 PST 2023


LuoYuanke added a comment.

In D145275#4168604 <https://reviews.llvm.org/D145275#4168604>, @efriedma wrote:

> Hoisting like this is completely unsafe; dynamic allocation is dynamic for a reason (because the allocation is variable size, or happens in a loop).
>
> How do you end up with IR that looks like "@hoist"?  clang shouldn't generate IR like that.

Can we ingore dynamic alloca like https://reviews.llvm.org/D145286?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145275/new/

https://reviews.llvm.org/D145275



More information about the llvm-commits mailing list