[PATCH] D145149: [UTC] Enable --function-signature by default
Alexander Richardson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 3 15:59:30 PST 2023
arichardson added inline comments.
================
Comment at: llvm/utils/UpdateTestChecks/common.py:252
args = parser.parse_args(argv[1:])
if argparse_callback is not None:
----------------
I think this would be the place to add `if args.version >= 2: args.function_signature = True`
================
Comment at: llvm/utils/update_cc_test_checks.py:352
func_dict, func, False,
- ti.args.function_signature,
ti.args.version,
----------------
Could we update function_signature to True if version == 2 after parsing? That would avoid the need for the new helper function.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145149/new/
https://reviews.llvm.org/D145149
More information about the llvm-commits
mailing list