[PATCH] D145023: [memprof] Refactor tests to generate binaries and profiles on the fly.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

lgtm - thanks! One small suggestion on the tests below.



================
Comment at: compiler-rt/test/memprof/TestCases/memprof_basic.c:15
+
+// RUN: %clang_memprof -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling -fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -Wl,-build-id -no-pie %s -o %t.memprofexe
+// RUN: env MEMPROF_OPTIONS=log_path=stdout %t.memprofexe > %t.memprofraw
----------------
I believe it is typical to put the RUN lines at the top above the source code, so it might be good to do that in these tests as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145023/new/

https://reviews.llvm.org/D145023