[PATCH] D144057: [GVN] permit GVN of non-local loads for ASAN unless undef or alloca is produced

Fri Mar 3 13:38:19 PST 2023

nickdesaulniers added a comment.

In D144057#4168117 <https://reviews.llvm.org/D144057#4168117>, @eugenis wrote:

> Not convinced that this is right. The original fix is for a false postive, not a false negative - i.e., we want to prevent speculation of a memory access that is not provably safe.
>
> See https://lists.llvm.org/pipermail/llvm-dev/2015-November/092484.html. Note that the report is on heap memory, not alloca.

I tested my change against the original bug report; the artifact is still live and linked from there. It does not regress the original false positive report.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144057/new/

https://reviews.llvm.org/D144057