[PATCH] D143229: [AutoUpgrade] Add flag to disable auto-upgrade

Fri Mar 3 13:37:50 PST 2023

nikic added a comment.

In D143229#4168183 <https://reviews.llvm.org/D143229#4168183>, @tejohnson wrote:

> In D143229#4168182 <https://reviews.llvm.org/D143229#4168182>, @nikic wrote:
>
>>> I may be wrong, but I believe rust does inter-crate (Thin)LTO, all bitcode produced from the same rustc frontend, which could also use this.
>>
>> Conceptually yes, we don't need verification for compiler-driven LTO (which is the default). We wouldn't be able to use it as implemented though, because we do need to auto-upgrade intrinsics in the initial IR, while this effectively "breaks" UpgradeCallsToIntrinsic().
>
> Perhaps then it should go back to the original version that just skipped the UpgradeDebugInfo during cross-module importing - would that work for you?

I believe that should work, yes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143229/new/

https://reviews.llvm.org/D143229