[PATCH] D143228: [Attributor] Add convergent abstract attribute

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

We also need a commit message describing what this commit does. In addition there are two minor nits below. Otherwise, LGTM. Once you updated the revision we'll land it for you



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:926
+  LLVM_DEBUG(if (ToRemove.size()) dbgs()
+                 << "[AAPointerInfo] Removing access from old offset bins\n";);
 
----------------
Can you undo the unrelated formatting changes.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:2917
+namespace {
+struct AAConvergentImpl : public AANonConvergent {
+  AAConvergentImpl(const IRPosition &IRP, Attributor &A)
----------------
AANonConvergentImpl


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143228/new/

https://reviews.llvm.org/D143228