[PATCH] D145263: [lld-macho] Remove duplicate minimum version info

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

Thanks Keith!



================
Comment at: lld/MachO/Driver.cpp:688
+parsePlatformVersions(const ArgList &args) {
   std::map<PlatformType, PlatformVersion> platformVersions;
   const PlatformVersion *lastVersionInfo = nullptr;
----------------
keith wrote:
> int3 wrote:
> > while we're here, could we change this to a `DenseMap` or `IndexedMap`?
> > 
> > Doesn't really matter for perf but we try to avoid `std::map` in general. And this might save some binary size
> it looks like both of those have new requirements for the key type, I will do it in a separate change to avoid noise in this diff
ah ok. No worries either way, it's not super important


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145263/new/

https://reviews.llvm.org/D145263