[PATCH] D144221: [amdgpu][nfc] Replace ad hoc LDS frame recalculation with absolute_symbol MD

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D144221#4152246 <https://reviews.llvm.org/D144221#4152246>, @JonChesterfield wrote:

> The primary drawback is that this uses metadata to convey information where we will miscompile if that metadata is removed, directly at odds with the design intent of metadata.

absolute_symbol is one of the few cases for global metadata which you are specifically not allowed to drop as per the LangRef.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144221/new/

https://reviews.llvm.org/D144221