[PATCH] D144337: Prevent line 0 instructions from dividing a lexical block into ranges

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

It seems strange to define the enum in a header for a module that uses it only once, and externalize it in a module that uses it several times.

I'd always thought this DefaultOnOff business should be generalized...  Hmm I see boolOrDefault in CommandLine.h.  Maybe we could convert UnknownLocations to use that, remove `static` from the definition, and then LexicalScopes.cpp can reference it as an extern.

(Converting the rest of the DwarfDebug.cpp options from DefaultOnOff to boolOrDefault should not be part of your task. But maybe add a FIXME on the enum definition.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144337/new/

https://reviews.llvm.org/D144337