[PATCH] D143513: [DebugInfo] Allow parsing line tables aligned to 4 or 8-byte boundaries

[Paul Robinson via Phabricator via llvm-commits]

probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

Tidy up the test and LGTM.



================
Comment at: llvm/test/tools/llvm-dwarfdump/ARM/aligned_line_tables.s:13
+# CHECK: debug_line[0x00000028]
+# CHECK-NOT: debug_line[0x00000027]
+# CHECK: Line table prologue:
----------------
This CHECK-NOT is unnecessary. If you've matched the 28 offset, that shows you've found the correct place.


================
Comment at: llvm/test/tools/llvm-dwarfdump/ARM/aligned_line_tables.s:16
+# CHECK:    total_length: 0x0000003a
+# CHECK-NOT:    total_length: 0x00003a00
+# CHECK:          format: DWARF32
----------------
Again this CHECK-NOT is unnecessary. You could modify the previous CHECK line to end with `3a{{$}}` to emphasize that nothing follows it.


================
Comment at: llvm/test/tools/llvm-dwarfdump/ARM/aligned_line_tables.s:19
+# CHECK:         version: 2
+# CHECK-NOT:         version: 512
+# CHECK: prologue_length: 0x0000001a
----------------
Same thing here; make the previous check `2{{$}}` (so it won't match something like 256) and remove the CHECK-NOT.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143513/new/

https://reviews.llvm.org/D143513