[PATCH] D145051: [ADCE] Only remove debug intrinsics if non debug instructions are removed

Fri Mar 3 03:41:44 PST 2023

uabelho added a comment.

In D145051#4166656 <https://reviews.llvm.org/D145051#4166656>, @nikic wrote:

> This caused a large compile-time regressions in some cases: http://llvm-compile-time-tracker.com/compare.php?from=57833636816a13ccda53714413c532dc81e3b5ff&to=8aa9ab336889ae2eb8e4188036faeb151379ab7b&stat=instructions:u In particular tramp3d-v4 with debuginfo regressed by 15%.
>
> So I think this is probably not the right way to fix this issue. I think what we can do instead is to mark MemorySSA as preserved if only debuginfo intrinsics have been removed. (This is safe, MSSA explicitly never tracks debuginfo intrinsics.)

Should I revert this for now then or do we leave it in-tree while determining what we do about it?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145051/new/

https://reviews.llvm.org/D145051