[PATCH] D145220: [X86][InstCombine] Simplify some `pternlog` intrinsics

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 3 00:46:53 PST 2023


pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstCombineIntrinsic.cpp:591-594
+  // Currently we only handle cases that convert directly to another instruction
+  // or cases where all the ops are constant.  This is because we don't properly
+  // handle creating ternary ops in the backend, so splitting them here may
+  // cause regressions. As the backend improves, uncomment more cases.
----------------
Maybe better to do it in FE and remove all these intrinsics finally?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145220/new/

https://reviews.llvm.org/D145220



More information about the llvm-commits mailing list