[PATCH] D145209: [DAE] Don't change the return type if we have virtual musttail calls
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 2 22:12:50 PST 2023
efriedma added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/DeadArgumentElimination.cpp:526
+ // In addition, if the called function is virtual, we can't change
+ // the return type.
+ if (!TC->getCalledFunction())
----------------
Please explain why this matters. Intuitively, whether a function is virtual shouldn't affect liveness... do we handle the non-virtual case somewhere else?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145209/new/
https://reviews.llvm.org/D145209
More information about the llvm-commits
mailing list