[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

Thu Mar 2 15:35:38 PST 2023

yln added inline comments.

================
Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11
+
+// darwin only supports shared-libsan, so this should fail.
+// XFAIL: darwin
+ 
----------------
zixuw wrote:
> dmaclach wrote:
> > yln wrote:
> > > This should work, right?
> > No.. darwin should fail with the `-static-libsan` flag. This is the test that was failing and caused the rollback.
> I think @yln is suggesting using `REQUIRES: asan-static-runtime` instead of `XFAIL: darwin`. I wasn't aware of that conditional but yeah that should be better if it works.
I meant using `// REQUIRES: asan-static-runtime ` instead of `XFAIL: darwin` since it seems that we already have a lit feature for it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144672/new/

https://reviews.llvm.org/D144672