[PATCH] D145200: [lld-macho] Ignore -debug_variant flag

[Keith Smiley via Phabricator via llvm-commits]

keith created this revision.
Herald added projects: lld-macho, All.
Herald added a reviewer: lld-macho.
keith requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

As far as I can tell all this flag does in ld64 is warn about cases
where you're building dylibs that are going to be part of the shared
cache, which I assume only apple is doing. Strangely I have seen this
flag being passed in the wild so this silences the warning about it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145200

Files:
  lld/MachO/Options.td
  lld/test/MachO/silent-ignore.s


Index: lld/test/MachO/silent-ignore.s
===================================================================
--- lld/test/MachO/silent-ignore.s
+++ lld/test/MachO/silent-ignore.s
@@ -20,7 +20,7 @@
 
 ## Check that we don't emit any warnings nor errors for these unimplemented flags.
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t.o
-# RUN: %lld %t.o -o /dev/null -objc_abi_version 2
+# RUN: %lld %t.o -o /dev/null -objc_abi_version 2 -debug_variant
 
 .globl _main
 _main:
Index: lld/MachO/Options.td
===================================================================
--- lld/MachO/Options.td
+++ lld/MachO/Options.td
@@ -687,10 +687,6 @@
     HelpText<"Suppress warnings for static initializers in the output">,
     Flags<[HelpHidden]>,
     Group<grp_rare>;
-def debug_variant : Flag<["-"], "debug_variant">,
-    HelpText<"Suppress warnings germane to binaries shipping to customers">,
-    Flags<[HelpHidden]>,
-    Group<grp_rare>;
 def unaligned_pointers : Separate<["-"], "unaligned_pointers">,
     MetaVarName<"<treatment>">,
     HelpText<"Handle unaligned pointers in __DATA segments according to <treatment>: warning, error, or suppress (default for arm64e is error, otherwise suppress)">,
@@ -1387,3 +1383,7 @@
     HelpText<"This option only applies to i386 in ld64">,
     Flags<[HelpHidden]>,
     Group<grp_ignored_silently>;
+def debug_variant : Flag<["-"], "debug_variant">,
+    HelpText<"Do not warn about issues that are only problems for binaries shipping to customers.">,
+    Flags<[HelpHidden]>,
+    Group<grp_ignored_silently>;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145200.502008.patch
Type: text/x-patch
Size: 1575 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230302/8a36daa0/attachment.bin>