[PATCH] D142282: [Support] Implement findModulesAndOffsets on Apple 64-bit platforms
Luís Marques via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 2 13:52:21 PST 2023
luismarques added a comment.
In D142282#4164562 <https://reviews.llvm.org/D142282#4164562>, @stefanp wrote:
> On AIX we end up without a definition for `findModulesAndOffsets` so very likely the combination of `#if, #elif, #else, #endif` is excluding AIX from all of the definitions and it did not do that before..
Sorry, I only noticed your message now. I just reverted this instead of fixing forward. I'll take the time tomorrow to check how to best fix this, potentially not just messing with the preprocessor conditions. Thanks @hubert.reinterpretcast for the review tip about the old code comment being wrong.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142282/new/
https://reviews.llvm.org/D142282
More information about the llvm-commits
mailing list