[PATCH] D143841: [Propeller] Make decoding BBAddrMaps trace through relocations

[Aiden Grossman via Phabricator via llvm-commits]

aidengrossman added inline comments.


================
Comment at: llvm/lib/Object/ELFObjectFile.cpp:696
       if (!TextSecOrErr)
-        return createError("unable to get the linked-to section for " +
-                           describe(EF, Sec) + ": " +
-                           toString(TextSecOrErr.takeError()));
+        return TextSecOrErr.takeError();
       if (*TextSectionIndex != std::distance(Sections.begin(), *TextSecOrErr))
----------------
rahmanl wrote:
> rahmanl wrote:
> > Let's use `reportError` here. `SHT_LLVM_BB_ADDR_MAP` should always link to a text section. We may have to change the ``llvm-objdump` tests a bit then.
> Disregard my previous comment. But is there a reason you are changing the error message?
I think I was messing around with the refactoring at some point and changed it. I've changed it back since there's no reason to change it to this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143841/new/

https://reviews.llvm.org/D143841