[llvm] 8fccdfa - [AMDGPU] Remove outdated FIXME in comments [NFC]
ZHU Zijia via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 2 09:35:16 PST 2023
Author: ZHU Zijia
Date: 2023-03-03T01:34:19+08:00
New Revision: 8fccdfa4366c85dada99f5ee71c3b8c242772342
URL: https://github.com/llvm/llvm-project/commit/8fccdfa4366c85dada99f5ee71c3b8c242772342
DIFF: https://github.com/llvm/llvm-project/commit/8fccdfa4366c85dada99f5ee71c3b8c242772342.diff
LOG: [AMDGPU] Remove outdated FIXME in comments [NFC]
This case has already been handled by D106449.
Added:
Modified:
llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp b/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
index 68267de90264b..669c6e07a0e33 100644
--- a/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
+++ b/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
@@ -2555,12 +2555,6 @@ void SIInstrInfo::insertIndirectBranch(MachineBasicBlock &MBB,
BuildMI(&MBB, DL, get(AMDGPU::S_SETPC_B64))
.addReg(PCReg);
- // FIXME: If spilling is necessary, this will fail because this scavenger has
- // no emergency stack slots. It is non-trivial to spill in this situation,
- // because the restore code needs to be specially placed after the
- // jump. BranchRelaxation then needs to be made aware of the newly inserted
- // block.
- //
// If a spill is needed for the pc register pair, we need to insert a spill
// restore block right before the destination block, and insert a short branch
// into the old destination block's fallthrough predecessor.
More information about the llvm-commits
mailing list