[llvm] 010a979 - [ADT] Drop append_range test that doesn't compile with EXPENSIVE_CHECKS

[Jakub Kuderski via llvm-commits]

Author: Jakub Kuderski
Date: 2023-03-02T11:26:20-05:00
New Revision: 010a97974a158ebca0bdb58346a2b303ab8a401e

URL: https://github.com/llvm/llvm-project/commit/010a97974a158ebca0bdb58346a2b303ab8a401e
DIFF: https://github.com/llvm/llvm-project/commit/010a97974a158ebca0bdb58346a2b303ab8a401e.diff

LOG: [ADT] Drop append_range test that doesn't compile with EXPENSIVE_CHECKS

The issue seems to be caused by the definition of `SafeIntIterator` and
is otherwise unrelated to the implementation of `append_range`.

We have a simialr test below, so this does not meaningfully decrease the
test coverage of `append_range`.

See the discussion in: https://reviews.llvm.org/D144420#4164373

Issue: https://github.com/llvm/llvm-project/issues/61122

Added: 
    

Modified: 
    llvm/unittests/ADT/STLExtrasTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/ADT/STLExtrasTest.cpp b/llvm/unittests/ADT/STLExtrasTest.cpp
index fda4577283d2e..a02b1dc8af22c 100644
--- a/llvm/unittests/ADT/STLExtrasTest.cpp
+++ b/llvm/unittests/ADT/STLExtrasTest.cpp
@@ -7,7 +7,6 @@
 //===----------------------------------------------------------------------===//
 
 #include "llvm/ADT/STLExtras.h"
-#include "llvm/ADT/Sequence.h"
 #include "llvm/ADT/StringRef.h"
 #include "gmock/gmock.h"
 #include "gtest/gtest.h"
@@ -405,9 +404,6 @@ TEST(STLExtrasTest, AppendRange) {
   append_range(V, AppendVals2);
   EXPECT_THAT(V, ElementsAre(1, 2, 3, 4, 5));
 
-  append_range(V, llvm::seq(6, 8));
-  EXPECT_THAT(V, ElementsAre(1, 2, 3, 4, 5, 6, 7));
-
   std::string Str;
   append_range(Str, "abc");
   EXPECT_THAT(Str, ElementsAre('a', 'b', 'c', '\0'));