[PATCH] D144420: [STLExtras] Allow for non-member `begin`/`end` in `append_range`

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added a comment.

Hi Jay,

In D144420#4164373 <https://reviews.llvm.org/D144420#4164373>, @foad wrote:

> Do you have any idea what is wrong here? Thanks!

Thanks for the error message, I was able to reproduce it on my system. The first thing I checked was whether `std::` vs. `adl_` matters here and I can see the same error with `std::begin`/`std::end`. Seems like the iterator debug code gets confused at some point and expects to be able to take an address of integers returned from `llvm::seq`. Digging in deeper now to see how to fix this...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144420/new/

https://reviews.llvm.org/D144420